Skip to content

feat/pdf-builder#22

Closed
NeurArk wants to merge 1 commit into
mainfrom
NeurArk/introduire-la-classe-pdfreportbuilder
Closed

feat/pdf-builder#22
NeurArk wants to merge 1 commit into
mainfrom
NeurArk/introduire-la-classe-pdfreportbuilder

Conversation

@NeurArk
Copy link
Copy Markdown
Owner

@NeurArk NeurArk commented May 19, 2025

What

  • add PdfReportBuilder with temp file cleanup
  • update create_pdf to use context manager
  • revise pdf tests to call builder directly

Why

  • ensure temporary files are cleaned automatically
  • expose flexible PDF building API

How

  • manage chart images in a TemporaryDirectory
  • adjust tests for new class API

Test Plan

  • ruff check tools/pdf_tool.py tests/test_pdf_tool.py tests/test_pdf_visuals.py
  • ruff format --check tools/pdf_tool.py tests/test_pdf_tool.py tests/test_pdf_visuals.py
  • mypy tools/pdf_tool.py tests/test_pdf_tool.py tests/test_pdf_visuals.py --ignore-missing-imports --python-version 3.12
  • bandit -r tools/ agent/ -ll -x /tests/
  • pytest -q --cov=tools --cov=agent --cov-report=term-missing --cov-fail-under=85 (fails: total coverage 54% < 85%)

MCP Impact

  • none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant